You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it. -> Not sure how I could achieve this here, as it would be a type error.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.
Tests
Run the tests with pnpm test:ci.
Tests fail on my branch, but the same tests also fail on the main branch. So it doesn't seem to be related to this PR changes.
Documentation
If you introduce new functionality, document it. You can run documentation with pnpm run docs command.
Changesets
Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
Sorry to bring up a dead thread, but is there any chance that beforeAll/afterAll would be supported. As mentioned, this is available in Playwright already. I understand that currently all fixtures are in the same bucket type-wise, so it makes sense from a typescript stance that they're not available in the *all hooks, in the off chance that someone tries to use a test-scoped context. Just curious if it's already in the roadmap, considering that this PR was reviewed and merged
Sorry to bring up a dead thread, but is there any chance that beforeAll/afterAll would be supported. As mentioned, this is available in Playwright already. I understand that currently all fixtures are in the same bucket type-wise, so it makes sense from a typescript stance that they're not available in the *all hooks, in the off chance that someone tries to use a test-scoped context. Just curious if it's already in the roadmap, considering that this PR was reviewed and merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds hooks to the
TestAPI(test), that provide type-safeExtraContext.Details can be viewed here: #8617.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Tests fail on my branch, but the same tests also fail on the
mainbranch. So it doesn't seem to be related to this PR changes.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.